perf: Replace Font Awesome with inline svg icons - #890
Merged
Conversation
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 16, 2026 07:26
30b206b to
f38363b
Compare
lfrancke
force-pushed
the
perf/fonts-and-caching
branch
from
July 16, 2026 07:34
ebb98f1 to
7af036a
Compare
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 16, 2026 07:34
f38363b to
c68ab8d
Compare
lfrancke
marked this pull request as draft
July 21, 2026 08:42
lfrancke
force-pushed
the
perf/fonts-and-caching
branch
from
July 21, 2026 08:50
7af036a to
1b9508a
Compare
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 21, 2026 08:50
c68ab8d to
c93fa90
Compare
lfrancke
force-pushed
the
perf/fonts-and-caching
branch
from
July 21, 2026 08:51
1b9508a to
455d079
Compare
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 21, 2026 08:51
c93fa90 to
1626ee0
Compare
lfrancke
force-pushed
the
perf/fonts-and-caching
branch
from
July 21, 2026 08:56
455d079 to
b322948
Compare
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 21, 2026 08:56
1626ee0 to
278b11d
Compare
Font Awesome shipped 137 kB of css and eight webfont files for seven glyphs: the external-link arrow, the search magnifier, the glossary link icon and four social icons in the footer. Those are inline svgs now (path data from Font Awesome Free 6.2.1, CC BY 4.0, attributed in ui/NOTICE), sized and colored via a small .svg-icon utility class. site.css shrinks from 146 kB to 48 kB and the webfonts/ directory disappears from the bundle. The fa-* checklist selectors in doc.css stay: they come from upstream and draw the check marks with css content, independent of any icon font. Also removes the inlineDynamicImports rollup option (vite 8 warns it is redundant for non-code-split builds).
lfrancke
marked this pull request as ready for review
July 28, 2026 07:19
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 28, 2026 07:19
278b11d to
4d4bc37
Compare
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
All seven icons live as symbols in img/icons.svg; usage sites reference them with <use>, which keeps the markup readable and the path data in one reusable, cacheable place. currentColor inheritance works through <use>, so the .svg-icon styling is unchanged. Antora relativizes the root-relative sprite url in page content, so the external-link-icon attribute works from any page depth. The universal-nav partials keep their own pre-existing inline svgs; they can move into the sprite when that area is next touched.
lfrancke
force-pushed
the
perf/fa-inline-svg
branch
from
July 28, 2026 07:45
8127bb8 to
ae0626b
Compare
Member
Author
|
It looks big (22 files) but once you look at it you'll see it's mostly removals. |
lfrancke
enabled auto-merge
July 28, 2026 08:22
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
NickLarsenNZ
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This builds on the work done in #889
And it continues the work to improve our PageSpeed scores.
This is what I get on the preview:
And this is what I get on the live site, so quite an improvement (you can ignore the SEO score, due to the preview URL):
What tihs does in a nutshell:
We used to ship all of the Font Awesome package + eight webfont files for seven symbols we used from those. So that's about 400kB of stuff gone from every page load 🥳
I let Claude inline those SVGs into one
icons.svgfile keeping proper attribution.Drive-by: removes the
inlineDynamicImportsrollup option that Vite 8 warns is redundant.The preview looks good to me. Look for the icons (external-link arrow in the top bar, content links, search icons, the social icons, ...). It all looks good to me.