Skip to content

docs: fix race-condition in getting-started script - #834

Merged
adwk67 merged 1 commit into
mainfrom
docs/fix-getting-started-26.11
Nov 9, 2026
Merged

adwk67 merged 1 commit into
mainfrom
docs/fix-getting-started-26.11

Conversation

@adwk67

@adwk67 adwk67 commented Nov 9, 2026

Copy link
Copy Markdown
Member

Description

Fixes a race condition by starting the commons/secret/listener operators first (the zookeeper-operator now watches for listeners, which was previously not the case).

Helm:

Time: 0.06 sec(s)

HO                    TOTAL_ACTIVE_VISITORS 
-- ---------------------------------------- 
EU                                      150 
NA                                        1 
Time: 0.019 sec(s)

Re-checking tables: found...
...14 expected tables. Success!

Stackablectl:

Time: 0.013 sec(s)

HO                    TOTAL_ACTIVE_VISITORS 
-- ---------------------------------------- 
EU                                      150 
NA                                        1 
Time: 0.061 sec(s)

Re-checking tables: found...
...14 expected tables. Success!

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Nov 9, 2026
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Nov 9, 2026
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 9, 2026
@NickLarsenNZ
NickLarsenNZ self-requested a review November 9, 2026 13:05

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why the ZK operator now watches Listeners.

@adwk67
adwk67 added this pull request to the merge queue Nov 9, 2026
@adwk67

adwk67 commented Nov 9, 2026 •

Copy link
Copy Markdown
Member Author

Curious why the ZK operator now watches Listeners.

It's so that it knows when its discovery config map is available/not available or has changed. More info here: stackabletech/zookeeper-operator#1105

Merged via the queue into main with commit b3e8fd8 Nov 9, 2026
11 checks passed
@adwk67
adwk67 deleted the docs/fix-getting-started-26.11 branch November 9, 2026 13:13
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Nov 10, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants