Skip to content

test(smoke): Apply Secret before HiveCluster to prevent a second ControllerRevision - #793

Merged
NickLarsenNZ merged 3 commits into
mainfrom
test/reorder-hive-secret
Nov 10, 2026
Merged

test(smoke): Apply Secret before HiveCluster to prevent a second ControllerRevision#793
NickLarsenNZ merged 3 commits into
mainfrom
test/reorder-hive-secret

Conversation

@NickLarsenNZ

@NickLarsenNZ NickLarsenNZ commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This was failing on AKS clusters due to a change in metadata.labels leading to a second ControllerRevision (when we assert metadata.generation == 1).

I have tested this again for one version to ensure it helped:

--- PASS: kuttl (214.08s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-4.2.0_opa-latest-1.20.2_openshift-false_s3-use-tls-true_opa-use-tls-true (213.18s)

@NickLarsenNZ NickLarsenNZ self-assigned this Nov 10, 2026
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Nov 10, 2026
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 10, 2026
sbernauer
sbernauer approved these changes Nov 10, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Funny this does not happen locally

@NickLarsenNZ
NickLarsenNZ added this pull request to the merge queue Nov 10, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Nov 10, 2026
Merged via the queue into main with commit 07cdf59 Nov 10, 2026
11 checks passed
@NickLarsenNZ
NickLarsenNZ deleted the test/reorder-hive-secret branch November 10, 2026 07:55
@NickLarsenNZ

NickLarsenNZ commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Thanks for fixing this! Funny this does not happen locally

Yeah, my guess is that locally, the initial reconcile of both the HiveCluster (creating an STS) and commons operator (adding the restarter label) happen before a ControllerRevision is created.

I would have expected the reverse, where the local API server isn't very busy and should reconcile STSs quickly.

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

release/26.7.0

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickLarsenNZ @sbernauer @lfrancke