Repository navigation
Conversation
Adds the containerdebug config (enabled, interval) from stackable-operator 0.122.0 to the metastore config and starts containerdebug from the validated, merged role group config.
Maleware
marked this pull request as ready for review
November 11, 2026 08:16
adwk67
self-requested a review
November 13, 2026 10:42
adwk67
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
adwk67
requested changes
Nov 13, 2026
adwk67
left a comment
adwk67
left a comment
Member
There was a problem hiding this comment.
We should mention in the docs that containerdebug can be turned off. Some of the comments made in the trino PR and this one probably apply to the other PRs too.
| - The logs of the `containerdebug` process are now collected by the Vector agent and forwarded to | ||
| the Vector aggregator ([#790]). | ||
| - The metastore now has a default affinity to the OPA Pods when OPA authorization is configured ([#772]). | ||
| - Add `containerdebug` config CRD ([#794]). |
Member
There was a problem hiding this comment.
Rather refer to the addition of the config.containerdebug field on roles and role groups.
| #[fragment_attrs(serde(default))] | ||
| pub affinity: StackableAffinity, | ||
|
|
||
| #[fragment_attrs(serde(default))] |
Member
There was a problem hiding this comment.
If this attribute was dropped for some reason, no test would catch it. There is no containerdebug test in validate.rs, and the new statefulset.rs test passes an already-validated value, so there is no test for what happens up until that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of stackabletech/issues#884
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker