Skip to content

feat(operator): add containerdebug CRD structure - #1308

Merged
Maleware merged 24 commits into
mainfrom
spike/containerdebug-switch
Nov 2, 2026
Merged

feat(operator): add containerdebug CRD structure#1308
Maleware merged 24 commits into
mainfrom
spike/containerdebug-switch

Conversation

@Maleware

@Maleware Maleware commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Core of stackabletech/issues#884

Trino-operator spike

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@Maleware Maleware self-assigned this Oct 21, 2026
@Maleware Maleware moved this to Development: In Progress in Stackable Engineering Oct 21, 2026
@Maleware Maleware changed the title containerdebug CRD and validation logic containerdebug: CRD and validation logic Oct 21, 2026
@Maleware Maleware mentioned this pull request Oct 29, 2026
Open
4 of 20 tasks
@Maleware
Maleware marked this pull request as ready for review October 29, 2026 12:37
@Maleware Maleware moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 29, 2026
@Maleware
Maleware requested a review from Techassi October 29, 2026 13:01
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 29, 2026
sbernauer
sbernauer requested changes Oct 29, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread crates/stackable-operator/src/crd/containerdebug/mod.rs Resolved
Comment thread crates/stackable-operator/src/crd/containerdebug/mod.rs Resolved
Comment thread crates/stackable-operator/src/crd/containerdebug/mod.rs Resolved
Comment thread crates/stackable-operator/CHANGELOG.md Resolved
Comment thread crates/stackable-operator/src/crd/containerdebug/mod.rs Resolved
@sbernauer

sbernauer commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@Maleware PR title pls :P

@Maleware @sbernauer
Apply code review (typos etc)
d61d980 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>
@Maleware Maleware changed the title containerdebug: CRD and validation logic feat(containerdebug): add switch and interval to CRD Oct 30, 2026
@Maleware Maleware mentioned this pull request Oct 30, 2026
Open
15 tasks
sbernauer
sbernauer approved these changes Oct 30, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked this confirms to the decision in https://github.com/stackabletech/decisions/issues/104 (including the wrong containerdebug casing :P)

@Maleware Maleware changed the title feat(containerdebug): add switch and interval to CRD feat(operator): add containerdebug CRD structure Oct 30, 2026
@Maleware
Maleware added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 99af3e9 Nov 2, 2026
5 checks passed
@Maleware
Maleware deleted the spike/containerdebug-switch branch November 2, 2026 08:50
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Nov 2, 2026
@Techassi Techassi mentioned this pull request Nov 2, 2026
Merged
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes
@Techassi Techassi Awaiting requested review from Techassi

Assignees

@Maleware Maleware

Labels

release/26.11.0

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maleware @sbernauer @lfrancke