fix: effect teardown on failed setup, computed throw recovery - #126
Open
nickchomey wants to merge 6 commits into
Open
fix: effect teardown on failed setup, computed throw recovery#126nickchomey wants to merge 6 commits into
nickchomey wants to merge 6 commits into
Conversation
…ped effects, failed setup leaks
… first eval recovers after dep change (link-in-finally fix)
…irst eval still links to subscriber (computed-throw issue)
…or on unrelated re-runs and direct re-read
…d of stale undefined
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few related bugs. It comes in 3 pairs of red tests/green fix commits.
Note that this Supersedes/rebases #119, which fixes #118. I didnt create an issue for the two new bugs i found and fixed
Bug 1 - effect / effectScope leave live subscriptions after failed setup
Tests:
Fix:
Bug 2 - computed throwing on first evaluation never recovers
Tests:
Fix:
Bug 3 - throwing computed returns stale undefined instead of re-throwing
Tests:
Fix: