feat(alb-waf): Onboard WAF managed rule set - #1534
Open
Fyusel wants to merge 1 commit into
Open
Conversation
STACKITCLI-442 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
onboard-waf-managed-rule-set
branch
from
August 14, 2026 09:28
87f28e9 to
c506935
Compare
Merging this branch changes the coverage (1 decrease, 8 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| } | ||
|
|
||
| func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) { | ||
| globalFlags := globalflags.Parse(p, cmd) |
Contributor
There was a problem hiding this comment.
Suggested change
| globalFlags := globalflags.Parse(p, cmd) | |
| globalFlags := globalflags.Parse(p, cmd) | |
| if globalFlags.ProjectId == "" { | |
| return nil, &errors.ProjectIdError{} | |
| } |
| } | ||
|
|
||
| func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) { | ||
| globalFlags := globalflags.Parse(p, cmd) |
Contributor
There was a problem hiding this comment.
Suggested change
| globalFlags := globalflags.Parse(p, cmd) | |
| globalFlags := globalflags.Parse(p, cmd) | |
| if globalFlags.ProjectId == "" { | |
| return nil, &errors.ProjectIdError{} | |
| } |
| } | ||
|
|
||
| func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel, error) { | ||
| globalFlags := globalflags.Parse(p, cmd) |
Contributor
There was a problem hiding this comment.
Suggested change
| globalFlags := globalflags.Parse(p, cmd) | |
| globalFlags := globalflags.Parse(p, cmd) | |
| if globalFlags.ProjectId == "" { | |
| return nil, &errors.ProjectIdError{} | |
| } |
| if response.NextPageId != nil { | ||
| nextPageID = *response.NextPageId | ||
| } | ||
| received += want |
Contributor
There was a problem hiding this comment.
Suggested change
| received += want | |
| received += len(response.Items) |
| } | ||
|
|
||
| func fetchManagedRuleSets(ctx context.Context, model *inputModel, apiClient *albwaf.APIClient) ([]albwaf.GetLimitedManagedRuleSetResponse, error) { | ||
| var nextPageID string |
Contributor
There was a problem hiding this comment.
this looks pagination AIP compliant, we could add a comment to replace this with the utils function we want to do in STACKITSDK-525
| } | ||
|
|
||
| func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) { | ||
| globalFlags := globalflags.Parse(p, cmd) |
Contributor
There was a problem hiding this comment.
Suggested change
| globalFlags := globalflags.Parse(p, cmd) | |
| globalFlags := globalflags.Parse(p, cmd) | |
| if globalFlags.ProjectId == "" { | |
| return nil, &errors.ProjectIdError{} | |
| } |
| content = append(content, table) | ||
|
|
||
| if resp.Groups != nil && len(*resp.Groups) > 0 { | ||
| for _, groupId := range utils.SortedKeys(*resp.Groups) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITCLI-442
Description
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)