Conversation
Fyusel
reviewed
Sep 15, 2026
| ACL: []string{"0.0.0.0/0"}, | ||
| BackupSchedule: "0 0/6 * * *", | ||
| FlavorId: testFlavorId, | ||
| BackupSchedule: utils.Ptr("0 0/6 * * *"), |
Contributor
There was a problem hiding this comment.
new () can be used instead of utils.Ptr()
(can be replaced everywhere)
| listFlavorsResp: &mongodbflex.ListFlavorsResponse{ | ||
| Flavors: []mongodbflex.InstanceFlavor{ | ||
| { | ||
| Id: utils.Ptr(testFlavorId), |
| return req, fmt.Errorf("get MongoDB Flex instance: %w", err) | ||
| var currentFlavor *mongodbflex.InstanceFlavor | ||
| for _, f := range flavors.Flavors { | ||
| if f.Id == currentInstance.Item.Flavor.Id { |
| } | ||
| model.FlavorId, err = getFlavorId(ctx, model, apiClient.DefaultAPI) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
This return should be kept, right?
If flavorId was not set and the flavorId cannot be obtained via cpu and ram then we cannot proceed here
| if err != nil { | ||
| return fmt.Errorf("get MongoDB Flex flavors: %w", err) | ||
| } | ||
|
|
| if err != nil { | ||
| return fmt.Errorf("get MongoDB Flex storages: %w", err) | ||
| } | ||
|
|
Fyusel
reviewed
Sep 15, 2026
|
|
||
| table := tables.NewTable() | ||
| table.SetTitle("Versions") | ||
| table.SetHeader("VERSION") |
Contributor
There was a problem hiding this comment.
nitpick: found during testing the table only has "VERSION".
So it looks like the following:
Versions
VERSION
8.0
7.0
Just an idea: We could remove the duplicate information?
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
GokceGK
force-pushed
the
feat/STACKITCLI-441-refactor-mongodbflex
branch
from
September 30, 2026 06:15
fd3fc6c to
0679364
Compare
| if err != nil { | ||
| return req, err | ||
| for _, flavor := range flavors.Flavors { | ||
| if *flavor.Cpu == *model.CPU && *flavor.Memory == *model.RAM { |
Contributor
There was a problem hiding this comment.
Potential nil pointer dereference when API does not specify CPU or memory
| return req, fmt.Errorf("get MongoDB Flex instance: %w", err) | ||
| var currentFlavor *mongodbflex.InstanceFlavor | ||
| for _, f := range flavors.Flavors { | ||
| if *f.Id == *currentInstance.Item.Flavor.Id { |
Contributor
There was a problem hiding this comment.
Here also potential nil pointer dereference. Probably won't happen in practice, but since the fields are optional in the API i think we should treat them as potentially nullable
Comment on lines
+212
to
+215
| currentInstance, err := apiClient.GetInstance(ctx, model.ProjectId, model.InstanceId, model.Region).Execute() | ||
| if err != nil { | ||
| return req, fmt.Errorf("get MongoDB Flex instance: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
We can move the GetInstance call inside the if blocks below, since we only need to call it when the user only specifies either CPU or RAM
Comment on lines
+50
to
+55
| versions, err := buildRequest(ctx, model, apiClient.DefaultAPI).Execute() | ||
| if err != nil { | ||
| return fmt.Errorf("get MongoDB Flex versions: %w", err) | ||
| } | ||
|
|
||
| return outputResult(params.Printer, model.OutputFormat, versions.Versions) |
Contributor
There was a problem hiding this comment.
--limit support missing? Or is it not required here?
Contributor
Author
There was a problem hiding this comment.
I think --limit is not needed in here. we only have 2 versions. In other db services, version list also does not have limit
relates to STACKITCLI-441
relates to STACKITCLI-441
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
relates to STACKITCLI-441
Co-authored-by: Jonas Schlecht <73650029+SerseusWasTaken@users.noreply.github.com>
GokceGK
force-pushed
the
feat/STACKITCLI-441-refactor-mongodbflex
branch
from
September 30, 2026 14:20
1fbf61d to
dcbe4c5
Compare
Merging this branch changes the coverage (4 decrease, 7 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-441
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)