feat(git): add ability for users to update git resources - #1634
feat(git): add ability for users to update git resources#1634tomkillen wants to merge 2 commits into
Conversation
| subcategory: "" | ||
| description: |- | ||
| Git Instance resource schema. | ||
| ~> This resource is in beta and may be subject to breaking changes in the future. Use with caution. See our guide https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources for how to opt-in to use beta resources. This resource currently does not support updates. Changing the ACLs, flavor, or name will trigger resource recreation. Update functionality will be added soon. In the meantime, please proceed with caution. To update these attributes, please open a support ticket. |
There was a problem hiding this comment.
Short note without any deep review: We're still consuming the v1beta STACKIT git API here, so this must stay marked as beta
| } | ||
|
|
||
| // toPatchPayload creates the payload to update a git instance | ||
| func toPatchPayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { |
There was a problem hiding this comment.
| func toPatchPayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { | |
| func toUpdatePayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { |
Your function is named toPatchPayload, the test is named TestToUpdatePayload. Keep it consistent.
If you need help making a decision, toUpdatePayload is the better name IMO. 😉
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
2 participants
Description
resolves #1633
Note: depends on adding the update waiter to stackit-sdk-go (see PR for stackit-sdk-go here stackitcloud/stackit-sdk-go#9328)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)