fix(iaas): read write only field correctly from the config model - #1694
Open
SerseusWasTaken wants to merge 2 commits into
Open
fix(iaas): read write only field correctly from the config model#1694SerseusWasTaken wants to merge 2 commits into
SerseusWasTaken wants to merge 2 commits into
Conversation
SerseusWasTaken
force-pushed
the
fix/fix-iaas-write-only-fields
branch
from
August 17, 2026 07:36
5ffcb52 to
e4cdcee
Compare
Relates to STACKITTPR-782
…lity Relates to STACKITTPR-782
SerseusWasTaken
force-pushed
the
fix/fix-iaas-write-only-fields
branch
from
August 17, 2026 07:41
e4cdcee to
2c2559d
Compare
rubenhoenle
reviewed
Aug 17, 2026
| // buildCreateRequest builds a resource.CreateRequest from a plan and a config model. | ||
| // Terraform populates write-only attribute values only in the config model - never in the plan or state model. | ||
| // That's why we need both, the plan model AND config model to build the request. | ||
| func buildCreateRequest(ctx context.Context, t *testing.T, schemaResp *resource.SchemaResponse, planModel, configModel *Model) resource.CreateRequest { |
Member
There was a problem hiding this comment.
I would actually prefer to have this tested via resource.UnitTest like e.g. here:
This is hard to mock then (I know), that's why I worked on #1663 . Will make your life easier in that regard 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the write-only field
KeyPayloadBase64WriteOnlyby reading it from the config model instead of plan model.Also adds a regression test based on mocking that verifies that the write only field is sent to the API.
Relates to STACKITTPR-782
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)