fix(operator): warn when VirtualMCPServer inline telemetry is ignored - #6408
Open
RaviTharuma wants to merge 2 commits into
Open
fix(operator): warn when VirtualMCPServer inline telemetry is ignored#6408RaviTharuma wants to merge 2 commits into
RaviTharuma wants to merge 2 commits into
Conversation
RaviTharuma
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
August 21, 2026 09:36
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
==========================================
- Coverage 78.02% 78.00% -0.03%
==========================================
Files 767 767
Lines 74273 74284 +11
==========================================
- Hits 57955 57947 -8
- Misses 16313 16332 +19
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
blkt
reviewed
Aug 24, 2026
Comment on lines
+50
to
+51
| usesIgnoredInline := vmcp.Spec.Config.Telemetry != nil && vmcp.Spec.TelemetryConfigRef == nil | ||
| r.emitInlineTelemetryIgnoredEvent(vmcp, usesIgnoredInline) |
Contributor
There was a problem hiding this comment.
nit: this is passing both vmcp and a boolean calculated on its fields. Is there a reason why vmcp.Spec.Config.Telemetry and vmcp.Spec.TelemetryConfigRef are evaluated outside? If not, would you mind reducing this to func emitInlineTelemetryIgnoredEvent(vmcp *mcpv1beta1.VirtualMCPServer) and do al the math in it?
Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
Review asked emitInlineTelemetryIgnoredEvent to take only the VirtualMCPServer and evaluate Spec.Config.Telemetry and Spec.TelemetryConfigRef inside the helper. Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/vmcp-inline-telemetry-warning
branch
from
August 30, 2026 13:02
fc67cfa to
c25df52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #6276 after closing #6277. Operator ignores spec.config.telemetry and emits a one-shot Warning (InlineTelemetryIgnored) when it is set without telemetryConfigRef. Docs no longer claim inline still works for operator vMCP. /metrics stays unregistered without the ref (HTTP 406).