mcmc_trace: officially support highlight and alpha arguments#554
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 35 35
Lines 6583 6583
=======================================
Hits 6504 6504
Misses 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
This is pretty straightforward, so going ahead and merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #552
The original intent was for highlighting to be done only with
mcmc_trace_highlight(), but since it actually works formcmc_trace()too we should officially support it. Right now we throw a warning saying the arguments are ignored but they actually aren't.