Skip to content

Fix pkgdown issues#156

Open
VisruthSK wants to merge 2 commits into
masterfrom
fix-pkgdown
Open

Fix pkgdown issues#156
VisruthSK wants to merge 2 commits into
masterfrom
fix-pkgdown

Conversation

@VisruthSK

Copy link
Copy Markdown
Member

Bumped Roxygen to 8.0.0 and fixed vignette. Closes #155.

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I noticed that should be updated. Otherwise let's see if the pkgdown workflow passes.

With __roxygen__ documentation enabled, we need to generate the documentation
for `lm_stan` and update the `NAMESPACE` so the function is exported, i.e.,
available to users when the package is installed. This can be done with the
function `roxygen2::roxygenize()`, which needs to be called twice initially.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available to users when the package is installed. Load the R source files directly when running `roxygen2::roxygenize()`, then call `rstan_config()` to
generate the Stan C++ code:

Comment on lines 241 to 242
try(roxygen2::roxygenize(load_code = rstantools_load_code), silent = TRUE)
roxygen2::roxygenize()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
roxygen2::roxygenize(load_code = roxygen2::load_source)
rstantools::rstan_config()

Comment thread DESCRIPTION
@@ -56,6 +56,6 @@ Suggests:
roxygen2 (>= 6.0.1),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
roxygen2 (>= 6.0.1),
roxygen2 (>= 7.0.0),

I think the new vignette should work with v7 or greater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkgdown workflow failing

2 participants