Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comb's boolean mode (the default) checks
+wordwith an unanchored lookahead,#(?=.*zakat)#iu. On a record without the word, it retries from every position and scans to the end each time: quadratic in record length.On a real site (2.4k–3.7k documents, 5–16 MB per index),
+zakat -ramadantook 9.7s, 18.5s and 26.9s on three indexes, versus ~0.5s with non-matching documents filtered out first.Fix: one
preg_match('#'.$word.'#iu', $record)per required word, a linear scan each. Anchoring the old pattern instead hitspcre.backtrack_limiton records over ~1 MB and silently drops them.Words are still not
preg_quoted, same as before. One intentional change: required words on different lines of a multi-line field now match (.didn't cross newlines).