Skip to content

feat: add stats/incr/nanrss#10082

Merged
Planeshifter merged 8 commits into
stdlib-js:developfrom
kanikasharma-18:nanrss-added
Jul 19, 2026
Merged

feat: add stats/incr/nanrss#10082
Planeshifter merged 8 commits into
stdlib-js:developfrom
kanikasharma-18:nanrss-added

Conversation

@kanikasharma-18

@kanikasharma-18 kanikasharma-18 commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Resolves #5622

Description

What is the purpose of this pull request?

This pull request:-

  • Adds an incremental residual sum of squares (RSS) accumulator.

  • Ignores NaN input values during accumulation.

  • Returns the previously accumulated RSS when inputs contain NaN

  • Passes all existing test cases and maintains backward compatibility.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Result of tests:-

Screenshot 2026-01-26 at 1 32 03 PM

Result for benchmark:-

Screenshot 2026-01-26 at 1 32 57 PM

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

@stdlib-js/reviewers

@kanikasharma-18
feat: added nanrss for nan handling
7034bed 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Feb 4, 2026
@kanikasharma-18
feat: added required changes
8839c78 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
feat: added changes
c0a7a29 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
feat: added some changes
889b964 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
feat: added ulpdiff
220ba5e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
kanikasharma-18 marked this pull request as ready for review February 23, 2026 08:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 23, 2026
@kanikasharma-18

kanikasharma-18 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

@nakul-krishnakumar @kgryte @Planeshifter Kindly review my PR.

Planeshifter
Planeshifter requested changes Mar 9, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Comment thread lib/node_modules/@stdlib/stats/incr/nanrss/README.md Outdated
Comment thread lib/node_modules/@stdlib/stats/incr/nanrss/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/stats/incr/nanrss/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/stats/incr/nanrss/README.md Outdated
Comment thread lib/node_modules/@stdlib/stats/incr/nanrss/docs/repl.txt
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026
This was referenced Jul 18, 2026
Closed
Closed
@Planeshifter Planeshifter changed the title feat: add stats/incr/nanrss feat: add stats/incr/nanrss Jul 19, 2026
@Planeshifter
Planeshifter requested a review from a team July 19, 2026 05:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 19, 2026
@stdlib-bot

stdlib-bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

Planeshifter
Planeshifter approved these changes Jul 19, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land now. 🎉

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 19, 2026
@stdlib-bot

stdlib-bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanrss`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10082
Closes: https://github.com/stdlib-js/stdlib/issues/5622

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 19, 2026
@Planeshifter
Planeshifter merged commit bafe226 into stdlib-js:develop Jul 19, 2026
32 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanrss

3 participants

@kanikasharma-18 @stdlib-bot @Planeshifter