Skip to content

test: migrate math/base/special/cbrtf to ULP-based testing#13552

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:refactor-ulp-cbrtf
Jul 20, 2026
Merged

test: migrate math/base/special/cbrtf to ULP-based testing#13552
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:refactor-ulp-cbrtf

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the @stdlib/math/base/special/cbrtf package tests from relative tolerance testing to ULP-based difference testing using isAlmostSameValue.
  • Removes all outdated delta and tol variables across the package test files.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team July 19, 2026 12:29
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 19, 2026
@ujjwalv01
ujjwalv01 force-pushed the refactor-ulp-cbrtf branch from 5ad3585 to 76df40f Compare July 19, 2026 12:34
@ujjwalv01
ujjwalv01 force-pushed the refactor-ulp-cbrtf branch from 76df40f to 0cee5bd Compare July 19, 2026 12:43
@stdlib-bot

stdlib-bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cbrtf $\\color{green}180/180$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}180/180$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title test: migrate math/base/special/cbrtf to ULP-based testing test: migrate math/base/special/cbrtf to ULP-based testing Jul 19, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Jul 19, 2026
Comment thread lib/node_modules/@stdlib/math/base/special/cbrtf/test/test.js Outdated
@kgryte kgryte added Needs Discussion Needs further discussion. Tests Pull requests specifically adding tests. labels Jul 19, 2026
@kgryte kgryte removed the Needs Discussion Needs further discussion. label Jul 20, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit 0cb00da into stdlib-js:develop Jul 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants