fix(@stdlib/net/http2-secure-server): renew expired self-signed test certificates#13558
Closed
Planeshifter wants to merge 1 commit into
Closed
fix(@stdlib/net/http2-secure-server): renew expired self-signed test certificates#13558Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
…certificates The job `Node.js v16` on workflow `macos_test` failed on develop with `Error [ERR_HTTP2_STREAM_CANCEL]: ... (caused by: certificate has expired)`, `code: 'CERT_HAS_EXPIRED'`. Root cause: the self-signed `localhost-cert.pem`/`localhost-privkey.pem` fixtures under `test/fixtures/` and `examples/` were generated with a 30-day validity window (2025-08-16 to 2025-09-15) that has since elapsed, so every HTTP/2 TLS handshake in the test suite now fails deterministically regardless of platform or Node version. This commit regenerates both certificate/key pairs as self-signed, `CN=localhost`, RSA-2048, SHA-256, with a 10-year validity window, matching the original parameters otherwise. Verified end-to-end with a standalone HTTP/2 client/server handshake against the regenerated fixtures. Ref: https://github.com/stdlib-js/stdlib/actions/runs/29681897148
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
|
Isn't this a duplicate PR? |
Member
Author
|
Yes — this duplicates #13330, opened 2026-07-06 for the same root cause, still open and passing CI. I missed the open-PR check before starting this one. Closing in favor of #13330. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@stdlib/net/http2-secure-serverexpired, breaking the package's TLS-based tests and example on every platform. Regenerated both self-signed cert/key pairs with a 10-year validity window instead of 30 days. No source code changed — PEM files only.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Failing run: macos_test / Node.js v16, branch
develop.Symptom:
Root cause:
test/fixtures/server.jsandexamples/index.jsboth start a local HTTP/2 TLS server using checked-in self-signed certs (test/fixtures/localhost-{cert,privkey}.pem,examples/localhost-{cert,privkey}.pem). Both were generated with a 30-day validity window (2025-08-16 to 2025-09-15) and expired. Every handshake in the suite fails, deterministically, on every platform and Node version, every run going forward. Not flaky — permanent until fixed.Fix: Regenerated both pairs: self-signed,
CN=localhost, RSA-2048, SHA-256, 10-year validity (openssl req -x509 -newkey rsa:2048 -sha256 -days 3650 -nodes -subj "/CN=localhost"). NosubjectAltName, matching the originals — tests connect by hostnamelocalhost, which matches CN, and Node's TLS verification doesn't require SAN when CN matches and no SAN extension is present.Validation:
openssl x509 -noout -datesconfirms new certs are not expired.openssl x509 -noout -modulusvsopenssl rsa -noout -modulus, md5) confirms each private key matches its cert, both directories.test/test.js'shttp2.connect('https://localhost:'+port, {ca: CERT}), run against both cert pairs: zero cert errors, successful round-trip.npm testin this sandbox — nonode_modules, andnpm installblocked by a registry min-release-age policy on atapetransitive dependency.Reviewer notes: One reviewer flagged, non-blocking, that
fix:vstest:as commit type is a judgment call since the diff touches bothtest/fixtures/andexamples/— defensible asfix:since it repairs broken observable behavior (a working handshake).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running an automated CI-failure investigation and fix routine: it identified the failing run, diagnosed the root cause, authored the fix, and drafted this description, all based on the linked CI failure log.
@stdlib-js/reviewers
Generated by Claude Code