test: migrate stats/base/dists/hypergeometric/mean to ULP-based assertions - #15235
Merged
Merged
Conversation
…ertions Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYRomVwa3KVswQ1745T3N7 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
kgryte
marked this pull request as ready for review
September 16, 2026 04:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/hypergeometric/meanfrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparisons with@stdlib/assert/is-almost-same-value.The ULP bounds were tightened to the measured minimum over the full Julia fixture set (100 cases):
test/test.js: 1 ULP. 80 of 100 fixture values are bit-exact; the maximum observed ULP difference is1(worst caseN = 176,K = 100,n = 47, returning26.704545454545457vs. an expected26.704545454545453). Lowering the bound to0fails 20 of the 100 assertions, so1is the minimum.test/test.native.js: 0 ULP. All 100 fixture values are bit-exact for the C implementation.The differing bounds follow from the JS and C implementations evaluating the mean with different operation orders, as described in JS vs C return values: JavaScript computes
n * ( K / N )(two roundings), while C computes( (double)n * (double)K ) / (double)N, where the product is exact for the fixture inputs and the single division is correctly rounded.Verification:
make test TESTS_FILTER=".*/stats/base/dists/hypergeometric/mean/.*"passes (120 assertions intest.js, 108 intest.native.js, 0 failing). The native addon was built locally viamake install-node-addons NODE_ADDONS_PATTERN="hypergeometric/mean", so the native tests were executed rather than skipped.make lint-javascript-tests TESTS_FILTER=".*/stats/base/dists/hypergeometric/mean/.*"is clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
test/test.native.jsuses a bound of0because the C implementation reproduces every fixture value exactly, whiletest/test.jsrequires1. Happy to align both files on1if a uniform per-package bound is preferred over the per-file measured minimum.Other
The
lint-editorconfig-filestarget could not be run in this environment, as theeditorconfig-checkerwrapper downloads its binary from a GitHub release that was not reachable. The changed files were checked manually against.editorconfiginstead: LF line endings, tab indentation, no trailing whitespace, and a final newline.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, mirrored the migration idiom from previously converted packages, measured the minimum passing ULP bounds against the fixture set, and ran the package tests and test linter locally.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01RYRomVwa3KVswQ1745T3N7
Generated by Claude Code