Skip to content

test: restore removed test file - #15237

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-09-15
Sep 16, 2026
Merged

kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-09-15

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

Follow-up fixes for commits merged to develop between 2026-09-14T16:19:57-07:00 (adb952a) and 2026-09-15T02:37:51-07:00 (c24d71e).

  • math/base/special: Fix: 5258215e0 clobbered lib/node_modules/@stdlib/math/base/special/test/test.js when adding tanhf, git recording the new package's lib/index.js as a rename of it and leaving directories.test in package.json pointing at nothing. Restored the test file verbatim from the parent commit.
  • fft/base/fftpack/float32/decompose: Fixes a doc bug from a697555: the refactor of fft/base/fftpack/float32/decompose rewrote two description lines in lib/node_modules/@stdlib/fft/base/fftpack/float32/decompose/docs/repl.txt to backtick N but left the original two in place, duplicating the paragraph in the REPL help. Removes the stale pair.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

All 43 commits merged to develop in the review window were audited for style guide compliance (against docs/style-guides and established reference packages) and scanned for bugs (diff-scoped logic, values, and documentation checks; the new tanhf implementation was executed against its Python-generated fixtures in both JS and C, and the new blas/ext/base/glast-index-greater-than-equal examples were hand-evaluated). Only objective, independently re-verified defects were fixed; anything requiring interpretation, judgment calls, or changes outside the window's diff was deliberately excluded. Notably excluded: fft/base/fftpack/float32/rffti still passing Float32Array workspaces to the refactored decompose — behavior is unchanged and a change would fall outside the reviewed diff.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was produced by a scheduled Claude Code review of the last 24 hours of commits merged to develop; the fixes were authored and validated by Claude Code.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5


Generated by Claude Code

The test file for the `math/base/special` namespace package was
accidentally removed when scaffolding `math/base/special/tanhf`
(see 5258215), leaving the namespace
package without tests and with a dangling `directories.test` entry.
This commit restores the file as it existed prior to removal.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
…mpose`

An incomplete find-and-replace in a697555
added updated description lines to the REPL help text without removing
the originals, resulting in duplicated, garbled text. This commit removes
the stale lines.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
The restored test file is a new file from git's perspective, so the
copyright notice must reference the current year per the copyright
year lint check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
@stdlib-bot

stdlib-bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte
kgryte marked this pull request as ready for review September 16, 2026 04:04
@kgryte
kgryte requested a review from a team September 16, 2026 04:04
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Sep 16, 2026
@kgryte

kgryte commented Sep 16, 2026

Copy link
Copy Markdown
Member

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Needs Review A pull request which needs code review. labels Sep 16, 2026

Copy link
Copy Markdown
Member Author

The Run affected tests failure on c42d57c is not this PR's: it comes in with the develop merge and reproduces verbatim on the develop tip (abd365a), which this PR's one-file diff (math/base/special/test/test.js) cannot affect.

Root cause: 7333861 updated fft/base/fftpack/float32/rffti to write factorization results through a Uint32Array view over the workspace (raw integer bits), but cosqi and sinqi — which delegate to rffti — still have tests (and doc examples) that read the factors back as Float32Array values. Reading integer bit patterns as float32 yields denormals, which is exactly what CI shows: expected 8, 2, 2, 4, got 1.12e-44, 2.8e-45, 2.8e-45, 5.6e-45 (the bit patterns of 8, 2, 2, 4). Deterministic, so a re-run won't help.

Proposed patch (not pushed here to avoid widening this PR into the in-flight integer-view migration): in cosqi/test/test.js and sinqi/test/test.js, read the factorization region through a Uint32Array view over the workspace buffer, following the pattern already used in rffti/test/test.js (fview = new Uint32Array( w.buffer, w.byteOffset, w.length )), and update the // returns <Float32Array>[ 8, 2, 2, 4 ] doc examples in both packages accordingly — i.e., the same refactor! treatment 7333861 gave rffti.


Generated by Claude Code

@kgryte kgryte changed the title fix: restore math/base/special tests and remove duplicated REPL text test: restore removed test file Sep 16, 2026
@kgryte
kgryte merged commit 3e1e509 into develop Sep 16, 2026
64 of 65 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-15 branch September 16, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants