chore: clean-up - #15238
Merged
Merged
chore: clean-up#15238
Conversation
Propagates fix from 4ffdd6f ("bench: fix require paths") to the remaining sibling packages whose `benchmark.ndarray.js` requires the package index rather than the `ndarray.js` implementation file directly: `gfill-by`, `gtril`, `gtril2triu`, `gtriu`, and `gtriu2tril`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0193GoGfzSGeNDiPuyhagU9j
Propagates fix from 1e05f05 ("chore: fix JavaScript lint errors") to the sibling canonical wrapper package: `String.prototype.toLowerCase` is restricted syntax, and the wrapper must call the builtin and suppress the rule, mirroring `string/base/uppercase`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0193GoGfzSGeNDiPuyhagU9j
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 15, 2026 18:57
kgryte
approved these changes
Sep 15, 2026
blas/ext/base ndarray benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating fixes merged to
developbetween 2026-09-14 16:19 (-0700) and 2026-09-15 11:37 (+0200) to sibling packages.Description
This pull request propagates two fixes merged to
developin the last 24 hours to sibling packages carrying the same defect.bench: fix require paths(4ffdd6f). This closes the same gap left by 4ffdd6f, applied to the five remaining offenders in the namespace:gfill-by,gtril,gtril2triu,gtriu, andgtriu2trilstill required the package index inbenchmark.ndarray.jsrather thanlib/ndarray.jsdirectly. Requiring the implementation file matches the convention already used by 385 of 392benchmark.ndarray.jsrequires underblas/ext/base.gfind-indexandgfind-last-indexare excluded here, as #15146 owns those families.@stdlib/blas/ext/base/gfill-by@stdlib/blas/ext/base/gtril@stdlib/blas/ext/base/gtril2triu@stdlib/blas/ext/base/gtriu@stdlib/blas/ext/base/gtriu2trilchore: fix JavaScript lint errors(1e05f05). Theno-restricted-syntaxrule blocks direct use ofString.prototype.toUpperCase/toLowerCase;@stdlib/string/base/lowercaseis the canonical builtin wrapper and must callstr.toLowerCase()directly, so the rule cannot be satisfied by rewriting the call. 1e05f05 fixed this exact situation in the sibling package (uppercase/lib/main.js) by adding// eslint-disable-line no-restricted-syntax;lowercase/lib/main.jscarried the identical latent violation and receives the identical suppression.@stdlib/string/base/lowercaseRelated Issues
No.
Questions
No.
Other
Validation. Candidate sites were enumerated by exact-signature search over each source commit's pattern, then screened through two independent validation passes, an adaptation pass, and a style-consistency pass; only sites confirmed by both independent passes were applied. Deliberately excluded:
blas/ext/baseindex-returning family benchmarks (*index-of*,*first-index-*,*last-index-*,gfind-index,gfind-last-index): owned by open PR refactor: fix inconsistencies across packages inblas/ext/base*#15146.benchmark.jsfiles requiring./../lib: the repository convention there is genuinely split (272 vs 353 in the namespace), so those sites are not clear-cut analogs of 4ffdd6f.stats/base/dists/chi/mean/lib/native.jsJSDoc type sync (d3eaad3 pattern): validation surfaced that the JS implementation returns0fork = 0while the C implementation returnsNaN(k < 0.0vsk <= 0.0guards), so the correct annotation is ambiguous. The JS/C divergence atk = 0is left for maintainer review rather than patched here.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated fix-propagation routine: commits merged to
developin the last 24 hours were scanned for generalizable fixes, and the equivalent fixes were applied to validated sibling packages.🤖 Generated with Claude Code
https://claude.ai/code/session_0193GoGfzSGeNDiPuyhagU9j
Generated by Claude Code