Repository navigation
bench: fix Boost function call in math/base/special/gamma1pm1 - #16557
Merged
kgryte merged 1 commit intoNov 10, 2026
Merged
Conversation
The Boost benchmark calls `boost::math::gamma1pm1`, which Boost has
never defined, so it has never compiled. Boost names the function
`tgamma1pm1`, following C's `tgamma`, where stdlib uses `gamma1pm1`.
Assisted-by: Claude Opus 5.5
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Description
This pull request:
math/base/special/gamma1pm1, which callsboost::math::gamma1pm1. Boost's function istgamma1pm1, so the benchmark hasn't compiled at any Boost version.Related Issues
No.
Questions
No.
Other
-std=c++14. The benchmark builds with no warnings and passes. It needs the C++14 change in build: compile C++ Boost benchmarks with C++14 #16556 to build.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Claude (Opus 5.5) found the failing call, made the change, and checked that the benchmark builds and runs. I reviewed the change and the PR description.
@stdlib-js/reviewers