Repository navigation
Conversation
Usernames are OIDC subjects verbatim, and ADFS subjects are base64, so
they can contain '/'. As a path segment such a username never reaches
DELETE /api/users/{username}; the platform answered 404. user delete now
calls DELETE /api/users?username= (removeUserFromTenant), which the
platform adds and which deprecates the path variant.
The spec is dev's plus the /api/users paths of steadybit/platform#2208,
which is not on dev yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BusinessMap: https://steadybitgmbh.kanbanize.com/ctrl_board/2/cards/26888
Platform: https://github.com/steadybit/platform/pull/2208
Merge only after the platform release that ships steadybit/platform#2208. Until then
api-compatibilityfails, because the prod spec has noremoveUserFromTenant.Problem
Usernames are OIDC subjects verbatim, and ADFS subjects are base64, so they can contain
/,+and=.user deleteput the username into the path (DELETE /api/users/{username}). A/there splits the path, and an encoded%2Fis rejected by the platform's firewall, so the platform answered 404.Change
user deletecalls the newDELETE /api/users?username=…(removeUserFromTenant). The platform keeps the path variant (removeUser) as deprecated, so the coverage check needs no entry for it./api/usersand/api/users/{username}paths taken from the platform branch, which is not on dev yet. Once the platform PR is merged, a plainfetchfrom dev should yield the same paths; re-running it before merging this is a good check.TestDeleteuses an ADFS-style username and asserts it arrives unchanged as theusernamequery parameter;TestDeleteRefusalsmoves to the new route.