Build Docker images from source instead of downloading binaries.#2605
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0377a8ebe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
fnando
changed the title
mootz12
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Build the
stellar/stellar-cliDocker image from source viacargo installinside the Dockerfile, and produce a multi-arch image by building each architecture on its own native runner before merging them into a single manifest.The
docker.ymlworkflow now runs a matrixbuildjob —linux/amd64onubuntu-latestandlinux/arm64onubuntu-24.04-arm— that pushes each platform image by digest, then amergejob assembles those digests into one manifest list (docker buildx imagetools create) under the computed tags. QEMU emulation is no longer used.Why
The current Docker image is broken (see stellar/stellar-cli-docker#16). The move to building the CLI from source means the image is compiled during the Docker build rather than copied in from a prebuilt binary. Compiling under QEMU emulation for a foreign architecture is prohibitively slow, so each architecture is built on a matching native runner and the results are combined into a single multi-arch manifest at publish time.
This is a temporary solution until
stellar/stellar-cli-dockerpublishes images.Known limitations
This is a stopgap; image publishing is expected to move to
stellar/stellar-cli-docker.