fix(MetaVerifier): add TCB bridge axiom for Lean 4.31 kernel compat - #8
Open
kondylidou wants to merge 2 commits into
Open
fix(MetaVerifier): add TCB bridge axiom for Lean 4.31 kernel compat#8kondylidou wants to merge 2 commits into
kondylidou wants to merge 2 commits into
Conversation
Mirror of Strata fix for issue #1442. The `_match_N` reduction change in Lean 4.31 also breaks `gen_smt_vcs_boole` via the identical `mv.assign hP` pattern in `genSMTVCsBooleUnsafe`. Add a per-theorem local axiom bridging `andN ps` → `smtVCsCorrectBoole` goal, making `translateQuery` part of the TCB as recommended by Joe Hendrix. Update demo.lean's `#guard_msgs` axiom list accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lean 4.31 changed kernel reduction of auxiliary match functions generated
by complex patterns in
denoteQueries/denoteTerm, breakinggen_smt_vcs_boole:mv.assign hPfails the kernel type-check becausethe kernel can no longer reduce
denoteQueries evcstoandN ps.Fix: at elaboration time, add a local axiom
(h : andN ps) → (denoteQueries evcs).getD Falseand assign
mv := bridgeAxiom hP. This makestranslateQuerypart ofthe TCB per Joe Hendrix's recommendation (strata-org/Strata#1442). The
axiom is only applied once the user has proved every individual VC
subgoal, and its name appears in
#print axioms— see the updatedguard in
demo.lean.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.