Skip to content

ci: fetch the cross-validation corpora from this repository - #612

Merged
polaz merged 1 commit into
mainfrom
ci/#611-corpora-release
Oct 20, 2026
Merged

polaz merged 1 commit into
mainfrom
ci/#611-corpora-release

Conversation

@polaz

@polaz polaz commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • The cross-validation job on main downloads its corpora from this repository's bench-corpora release instead of the publishing hosts, one of which answers GitHub-hosted runners with 403.

Changes

  • scripts/cross-validate.sh: silesia, canterbury and enwik8 come from releases/download/bench-corpora, checked against the same SHA-256 digests as the original archives.

Testing

  • The three release assets download through fetch_verified and match their digests. The job itself runs only on pushes to main, so it is exercised after merge.

Closes #611

Summary by CodeRabbit

  • Chores
    • Benchmark archives are now downloaded from a different source. Existing integrity checks and destination paths are unchanged.

The cross-validation job on main failed on every run: after the
reference CLI built, the first corpus download got 403 from the
publishing host, which refuses GitHub-hosted runners. The silesia,
canterbury and enwik8 archives now come from the repository's
bench-corpora release, byte-identical to the originals and checked
against the same digests.

Closes #611
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:12:47.116155Z 27893cc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: structured-world/structured-zstd/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 246dec6f-71c1-4bf8-83d4-ba12f825aee8
📥 Commits

Reviewing files that changed from the base of the PR and between 3472973 and 27893cc.

📒 Files selected for processing: 1
  • scripts/cross-validate.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The cross-validation script now downloads the Silesia, Canterbury, and enwik8 archives from the repository’s bench-corpora release. It retains the existing SHA-256 digests and destination paths.

Changes: Cross-validation corpus downloads

Layer / File(s) Summary
Update corpus download sources
scripts/cross-validate.sh
The three corpus URLs now use the bench-corpora release. The script retains the existing digest checks and output paths.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 27893

The cross-validation script now downloads the three corpora from the repository release and rejects digest mismatches. The assets match the configured hashes, leaving no identified merge-blocking risk.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive For issue #611, scripts/cross-validate.sh now downloads silesia.zip, cantrbry.tar.gz, and enwik8.zip from the bench-corpora release URL. It retains the three required SHA-256 digests and pas… Provide reviewable evidence for the bench-corpora release metadata and assets, including the non-latest status and the three asset digests, plus evidence that the main cross-validation job passes the corpus download step.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating CI to fetch the cross-validation corpora from this repository.
Out of Scope Changes check Passed The whole-PR diff changes only scripts/cross-validate.sh. The URL changes, digest retention, and explanatory comment directly implement issue #611. No unrelated production or workflow changes are pr…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes only scripts/cross-validate.sh. The URL changes, digest retention, and explanatory comment directly implement issue #611. No unrelated production or workflow changes are present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Linked Issues check

Explanation

For issue #611, scripts/cross-validate.sh now downloads silesia.zip, cantrbry.tar.gz, and enwik8.zip from the bench-corpora release URL. It retains the three required SHA-256 digests and passes each download to fetch_verified. The reviewed repository does not contain the GitHub release assets or release metadata. Therefore, this evidence cannot establish that the assets are byte-identical to the originals, that the release is not marked latest, or that the main job gets past the downloads. The PR description reports successful downloads and digest checks, but it does not provide reviewable evidence for the release metadata or a main run.

Resolution

Provide reviewable evidence for the bench-corpora release metadata and assets, including the non-latest status and the three asset digests, plus evidence that the main cross-validation job passes the corpus download step.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@polaz
polaz merged commit a620b6d into main Oct 20, 2026
35 checks passed
@polaz
polaz deleted the ci/#611-corpora-release branch October 20, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: serve the cross-validation corpora from this repository

1 participant