[sophora-ugc] [sophora-ugc-proxy] add ServiceMonitors - #304
Draft
mlautzas wants to merge 6 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional Prometheus Operator ServiceMonitor resources to the sophora-ugc and sophora-ugc-proxy Helm charts, including wiring Service port names so the monitors can target the correct port.
Changes:
- Add configurable
serviceMonitorvalues and newServiceMonitortemplates for UGC, UGC multimedia, and UGC proxy. - Name Service ports
httpsoServiceMonitor.spec.endpoints[].port: httpresolves correctly. - Bump chart versions and update Artifact Hub change annotations.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sophora-ugc/values.yaml | Adds ugc.serviceMonitor and ugcMultimedia.serviceMonitor configuration defaults. |
| charts/sophora-ugc/templates/webapp-service.yaml | Names the Service port http for ServiceMonitor compatibility. |
| charts/sophora-ugc/templates/servicemonitor.yaml | New ServiceMonitor for UGC webapp metrics scraping. |
| charts/sophora-ugc/templates/ugc-multimedia/multimedia-service.yaml | Names the multimedia Service port http for ServiceMonitor compatibility. |
| charts/sophora-ugc/templates/ugc-multimedia/servicemonitor.yaml | New ServiceMonitor for UGC multimedia metrics scraping. |
| charts/sophora-ugc/templates/deployment.yaml | Renames container port 1694 from jolokia to management. |
| charts/sophora-ugc/Chart.yaml | Bumps chart version and updates Artifact Hub changelog. |
| charts/sophora-ugc-proxy/values.yaml | Adds top-level serviceMonitor configuration defaults. |
| charts/sophora-ugc-proxy/templates/service.yaml | Names the Service port http for ServiceMonitor compatibility. |
| charts/sophora-ugc-proxy/templates/servicemonitor.yaml | New ServiceMonitor for UGC proxy metrics scraping. |
| charts/sophora-ugc-proxy/Chart.yaml | Bumps chart version and updates Artifact Hub changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.