Repository navigation
fix(isthmus)!: use divisor scale for decimal division - #1417
Draft
alexandrefimov wants to merge 1 commit into
Draft
alexandrefimov wants to merge 1 commit into
alexandrefimov wants to merge 1 commit into
Conversation
Match the corrected decimal divide rule when exporting SQL plans. Cover bounded derivation, nullable operands, strict binding validation, and preservation of previously declared types during import and export. BREAKING CHANGE: SQL decimal division can produce a different result type. The corrected Substrait extension catalog is required alongside this change.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Isthmus decimal division types with the corrected Substrait formula. Add regression coverage for SQL export, strict binding validation and preservation of declared types when importing and re-exporting existing plans.
Blocked on the spec correction in Substrait issue 1216 and a substrait-packaging release containing it. The packaging pin still needs updating. Validation used a local overlay of the corrected catalog.
BREAKING CHANGE: SQL decimal division can produce a different precision and scale. This change requires the corrected extension catalog.