remove xdotool check#3
Open
teto wants to merge 1 commit into
Open
Conversation
Author
|
@sunjon any comment ? |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is no need to check that xdotool exists at that specific path '/usr/bin/xdotool', I could have installed a fork at '/usr/local/bin/xdotool'. Mine currently lives at /etc/profiles/per-user/teto/bin/xdotool. One check could be that it is in PATH.
Even better would be to check errors from vim.fn.system or add a checkhealth file.
This current change allowed me to create a simple package for nix.