Repository navigation
fix(examples): copy only chain-specific shared dirs into generated apps - #95
Merged
Merged
Conversation
eminn
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-example.mjscopies every directory inexamples/shared/into each generated app. Since chore(examples): move ABIs and IDLs to shared directory #93 moved ABIs and IDLs there, EVM apps receiveidl/settlement_sale.ts, which imports@coral-xyz/anchor. EVM apps don't install it, sorelease-examples.shfails attscforreact-evm.abi/for EVM apps,idl/for SVM apps. All other shared directories are still copied to every app.Test Plan
node examples/scripts/generate-example.mjs <app>builds successfully forreact-evm,react-svm,nextjs-evmandnextjs-svmsrc/containsabi/only for EVM apps andidl/only for SVM appsGenerated with Toshi