chore(api): simplify OpenAPI sync workflow#5602
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@9e9453e7601931c485c41d55a5241b8e3c13c403Preview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4115e9bcf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
chore/api-openapi-sync-detector
branch
from
4115e9b to
36fb7ac
Compare
jgoux
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36fb7ac96b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
chore/api-openapi-sync-detector
branch
from
36fb7ac to
f27217d
Compare
jgoux
force-pushed
the
chore/api-openapi-sync-detector
branch
from
f27217d to
9e9453e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e9453e760
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
The scheduled API package sync workflow was failing because its inline OpenAPI comparison logic drifted from the package generator. In particular, the workflow reimplemented override handling in jq, so adding new override operations could break the detector before the real generator ever ran.
This removes the custom detector job and makes the workflow use
pnpm generateas the source of truth on every scheduled run. The workflow now regenerates the API package, formats it, checks for changes underpackages/api/src/generated, and only creates a sync PR when generated output actually changes.This also removes the stale
high_availabilityadd override now that the upstream spec includes that field directly, and refreshes the generated API files for the current upstream spec.Reviewer context: future OpenAPI override operation support only needs to be implemented in the generator path; the workflow no longer has a second override interpreter to keep in sync.