fix(cli): improve local start diagnostics#5616
Open
jgoux wants to merge 1 commit into
Open
Conversation
jgoux
force-pushed
the
fix/issue-3265-local-start
branch
2 times, most recently
from
da530ca to
3bfcaa3
Compare
jgoux
force-pushed
the
fix/issue-3265-local-start
branch
2 times, most recently
from
b5626fe to
ff01bdf
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff01bdf683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@5beb860297727a98cdcbbe3e965c94cc8718171dPreview package for commit |
jgoux
force-pushed
the
fix/issue-3265-local-start
branch
from
ff01bdf to
5beb860
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This improves local stack startup behavior in the Go CLI path used by the TypeScript legacy wrappers.
When a local API request fails because the configured API port returns a malformed HTTP response, the CLI now adds a targeted hint that another process may be listening on that port. The hint includes the configured port, an
lsofcommand to identify the listener, and theapi.portconfig field to change when the port is intentionally occupied.Startup also now waits for all started services to pass health checks before seeding storage buckets declared in
[storage.buckets]. This keeps bucket creation from appearing to be the failing step when another service, especially edge runtime, has not become healthy yet.The edge-runtime main service keeps its regular remote module imports. This PR does not change the edge-runtime module graph; it focuses on making local-start failures easier to diagnose and preserving clearer startup ordering.
Why
Issue #3265 has shown two recurring local-start failure patterns: a misleading malformed
/storage/v1/bucketresponse when another process owns the API port, and bucket seeding logs appearing before edge runtime health failures. These changes make the port-conflict case self-diagnosing and ensure storage bucket seeding only runs after the local stack is healthy.