feat(stack): run the complete native service graph - #6385
Conversation
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1515d4700
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c912c31e38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a0834d944
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fe089ab55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Automated review convergence checkpoint after three batched fix rounds:
The automated loop is now capped per AGENTS.md because new findings are primarily in code introduced by prior bot-driven rounds. Please provide human review, especially on whether Storage restart persistence should be folded into CLI-2141 before merge or tracked separately. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69acdd0e84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
avallete
left a comment
avallete
left a comment
There was a problem hiding this comment.
Review
Cross-reviewed the stacked diff (ccbf5c5...69acdd0) only: Cursor + Claude Fable + Codex. Graph wiring, companions, journals, version planning, and eager/lazy/explicit prepare closures look coherent. Remaining problems sit at the host-native seam this PR introduced.
Changes requested — three small, diff-local fixes. Storage wipe is a follow-up, not a hold.
Ask before merge
- Native Analytics / BEAM cookies —
analytics.tsstill usesRELEASE_COOKIE: "cookie"on the host EPMD. Thread a random per-stack cookie to Analytics/Realtime/Pooler and bind epmd/dist to loopback. See inline. - Native PgMeta bind — set
PG_META_HOST=127.0.0.1. It is the only native HTTP service left on0.0.0.0. See inline. - Realtime
Hostprobe on Node — native health check setsHost: <tenantId>viafetch. Please confirm Node does not strip it; Bun e2e would miss that. See inline.
Parked (do not hold CLI-2141)
- Storage/Mailpit
orphanCleanupon requested stop/restart is real (supervisor-runtime.tsruns cleanup onShutdownRequested). CLI managed start always passes a persistedstackRoot, sosupabase start/stop/restartdoes not wipe uploads. The wart is programmaticcreateStack()temp roots and mid-sessionrestartService("storage")there — same parent contract already on Postgres. Fix in process-compose:RemovePathonly on owner loss. - imgproxy
IMGPROXY_LOCAL_FILESYSTEM_ROOT: "/"stays with CLI-2227; native blast radius is wider than Docker. start --moderestamping the previous mode's versions is anext/consumer follow-up, not the stack graph.- Realtime
ERL_CRASH_DUMPat cwd, missingruntime.envfootprint profile, and the NativeLogWriter NUL sentinel leaking throughLogBufferare real ownership/DX misses. Follow-up.
Cleanup
No review/tool attributions. Leftovers worth trimming if you are already in the files:
- Pooler native env asserted twice (
services.unit.test.tsandpooler.unit.test.ts). orphanCleanupcopied instorage.ts/mailpit.ts.- Dead aliases after
applyNativeDefaultsremoval (supervisor.tsruntimeConfigInput,SupervisorUpgradeRestart.tseffectiveConfigInput). startNativeLogWriterexported fromeffect.tswith onlyLocalStackas a consumer.- e2e
bindAndCloseafter dispose is released-port reuse; the PID check is enough.
Cross-review logs: Claude Fable + Codex on the stacked head. Nothing else posted besides this review.
69acdd0 to
246d59d
Compare
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@0c269ae78d5974606085f1ec7540a86fe331af35Preview package for commit |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 246d59d7bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f3f0fbf21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
cli/packages/stack/src/createStack.ts
Line 230 in 45588eb
Wait for the 503 response to finish before disposing
When lazy service activation fails on a slow or loaded host, this fixed 25 ms delay can expire before the handler's 503 response has flushed, after which disposing the managed runtime closes the proxy and the client observes a reset or truncated response instead of Service unavailable. Coordinate teardown with completion of the active request/response rather than using a timing assumption.
AGENTS.md reference: AGENTS.md:L320-L322
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfe88c32f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…1-stack-run-the-remaining-native-service-graph-from-slim
…1-stack-run-the-remaining-native-service-graph-from-slim
|
|
||
| const realtimeEnv = (opts: RealtimeEnvOptions): Record<string, string> => { | ||
| return { | ||
| PORT: String(opts.port), |
There was a problem hiding this comment.
🟡 Severity: MEDIUM
Native Realtime is now launched directly on the host, but its environment sets only PORT and no HTTP bind address. The Phoenix listener therefore uses its all-interface default; a network client can bypass the API proxy and reach Realtime directly, avoiding proxy-side key translation and exposing its HTTP/WebSocket surface.
Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Add PHX_HTTP_IP: "127.0.0.1" to the realtimeNativeEnv function alongside the existing loopback settings (GEN_RPC_SOCKET_IP). This follows the same pattern used by the Analytics service (PHX_HTTP_IP in analytics.ts) to restrict the Phoenix HTTP/WebSocket listener to the loopback interface only, preventing external clients from bypassing the API proxy and reaching Realtime directly. The change should be placed in realtimeNativeEnv (around line 86) rather than realtimeEnv, so Docker deployments (which legitimately bind to all interfaces within their network namespace) are not affected:
const realtimeNativeEnv = (
opts: Omit<RealtimeEnvOptions, "native">,
genRpcPort: number,
): Record<string, string> => ({
...realtimeEnv({ ...opts, native: true }),
// The local stack has one Realtime node. Keep each helper's gen_rpc listener
// on loopback and give it a distinct port during sequential startup.
PHX_HTTP_IP: "127.0.0.1",
GEN_RPC_SOCKET_IP: "127.0.0.1",
GEN_RPC_TCP_SERVER_PORT: String(genRpcPort),
GEN_RPC_TCP_CLIENT_PORT: String(genRpcPort),
});| paths.configPath, | ||
| nativeVectorConfig(opts), | ||
| "Failed to write the native Vector configuration", | ||
| { flag: "w", mode: 0o600 }, |
There was a problem hiding this comment.
⚪ Severity: LOW
The generated native Vector YAML embeds analyticsApiKey in plaintext. Passing mode: 0o600 to writeFileString with flag: "w" only controls creation; an existing permissive vector.yaml keeps its mode, so a shared or caller-supplied runtime root can expose the Analytics credential to other local users.
Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: The mode: 0o600 option passed to writeFileString (via writeNativeFile) only sets the file permissions when the file is newly created; if vector.yaml already exists on disk, flag: "w" truncates and overwrites the content but leaves the pre-existing file mode intact, potentially exposing the analyticsApiKey to other local users.
The recommended fix is to explicitly chmod the file after writing it, so permissions are always enforced regardless of the file's prior existence. In packages/stack/src/native-filesystem.ts, update writeNativeFile to call fs.chmod after fs.writeFileString when a mode is specified:
export const writeNativeFile = (
path: string,
content: string,
detail: string,
options?: WriteFileOptions,
): Effect.Effect<void, StackBuildError, FileSystem.FileSystem> =>
Effect.gen(function* () {
const fs = yield* FileSystem.FileSystem;
yield* fs
.writeFileString(path, content, options)
.pipe(Effect.mapError((cause) => new StackBuildError({ detail, cause })));
if (options?.mode !== undefined) {
yield* fs
.chmod(path, options.mode)
.pipe(Effect.mapError((cause) => new StackBuildError({ detail, cause })));
}
});Alternatively, inside prepareVectorConfig in vector.ts, add an explicit chmod call immediately after the writeNativeFile yield at line 162 using the FileSystem.FileSystem service to lock down the config file's permissions unconditionally.
2 participants
Summary
Extends the strict native stack runtime from the Postgres/Auth/PostgREST core to the complete service graph using the frozen slim-services releases.
Adds native launch, configuration, lifecycle, and private companion ownership for Edge Runtime, Realtime, Storage/imgproxy, PgMeta/Studio, Analytics/Vector, Pooler, and Mailpit. Native logs remain supervisor-owned and isolated per stack, while the public package surface preserves eager, lazy, and explicit preparation closure semantics.
The representative consumer journey covers the public service graph and exact resource ownership. This change does not add per-service Docker fallback or absorb unrelated proxy hardening.