Skip to content

test(cli): cover postgres-config get, update and delete (CLI-2271) - #6427

Merged
7ttp merged 4 commits into
developfrom
7ttp/cli-2271-postgres-config-command-family-coverage
Sep 2, 2026
Merged

test(cli): cover postgres-config get, update and delete (CLI-2271)#6427
7ttp merged 4 commits into
developfrom
7ttp/cli-2271-postgres-config-command-family-coverage

Conversation

@7ttp

@7ttp 7ttp commented Sep 1, 2026

Copy link
Copy Markdown
Member

TL;DR

adds live e2e coverage for postgres-config get, update, and delete, covering the postgres-config command family

whats introduced?

  • postgres-config get: reads the target project's config and proves a json object payload on stdout
  • postgres-config update: applies a work_mem override with --no-restart, proves the row in its own output and through get, then removes it
  • postgres-config delete: seeds a override, proves it landed, deletes it, and proves get no longer returns the key

ref:

  • closes: CLI-2271

@7ttp 7ttp self-assigned this Sep 1, 2026
@7ttp
7ttp requested a review from a team as a code owner September 1, 2026 19:28
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@0ab753637c0efbab1e10c023d47957327ea08d31

Preview package for commit 0ab7536.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

The six reviewer reports deduplicate to five findings. The shared get-test finding is confirmed as a minor assertion gap; the remaining four Claude-only findings are confirmed as nits concerning cleanup accuracy/efficiency, live-test scope, and duplication. No production-code correctness defect was identified.

Findings

Severity Location Category Sources Claim
🟡 MINOR apps/cli/src/legacy/commands/postgres-config/get/get.live.test.ts:20 test-coverage claude+codex The test's payload-shape assertion accepts JSON null and arrays despite claiming to verify a JSON object.
⚪ NIT apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts:6 documentation claude The comment overstates that the test leaves the shared project unchanged because cleanup deletes the seeded key instead of restoring a pre-existing value.
⚪ NIT apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts:47 test-efficiency claude The successful path performs a redundant second delete during cleanup, adding another Management API GET and PUT.
⚪ NIT apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts:21 test-scope claude The live test unnecessarily couples its golden-path check to the pretty table's spacing and pipe delimiter.
⚪ NIT apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts:8 maintainability claude The update and delete live tests duplicate their common target flags and postgres-config deletion cleanup scaffolding.

Stats

Claude findings: 5 · Codex findings: 1 · Confirmed: 5 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/legacy/commands/postgres-config/get/get.live.test.ts Outdated
Comment thread apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts Outdated
Comment thread apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts Outdated
Comment thread apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts Outdated
Comment thread apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts Outdated
@7ttp
7ttp added this pull request to the merge queue Sep 2, 2026
Merged via the queue into develop with commit db1856d Sep 2, 2026
66 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2271-postgres-config-command-family-coverage branch September 2, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants