test(cli): cover postgres-config get, update and delete (CLI-2271) - #6427
Merged
7ttp merged 4 commits intoSep 2, 2026
Merged
Conversation
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@0ab753637c0efbab1e10c023d47957327ea08d31Preview package for commit |
Contributor
There was a problem hiding this comment.
🤖 AI Review
The six reviewer reports deduplicate to five findings. The shared get-test finding is confirmed as a minor assertion gap; the remaining four Claude-only findings are confirmed as nits concerning cleanup accuracy/efficiency, live-test scope, and duplication. No production-code correctness defect was identified.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/legacy/commands/postgres-config/get/get.live.test.ts:20 |
test-coverage |
claude+codex | The test's payload-shape assertion accepts JSON null and arrays despite claiming to verify a JSON object. |
| ⚪ NIT | apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts:6 |
documentation |
claude | The comment overstates that the test leaves the shared project unchanged because cleanup deletes the seeded key instead of restoring a pre-existing value. |
| ⚪ NIT | apps/cli/src/legacy/commands/postgres-config/delete/delete.live.test.ts:47 |
test-efficiency |
claude | The successful path performs a redundant second delete during cleanup, adding another Management API GET and PUT. |
| ⚪ NIT | apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts:21 |
test-scope |
claude | The live test unnecessarily couples its golden-path check to the pretty table's spacing and pipe delimiter. |
| ⚪ NIT | apps/cli/src/legacy/commands/postgres-config/update/update.live.test.ts:8 |
maintainability |
claude | The update and delete live tests duplicate their common target flags and postgres-config deletion cleanup scaffolding. |
Stats
Claude findings: 5 · Codex findings: 1 · Confirmed: 5 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Coly010
approved these changes
Sep 2, 2026
7ttp
deleted the
7ttp/cli-2271-postgres-config-command-family-coverage
branch
September 2, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
adds live e2e coverage for
postgres-config get,update, anddelete, covering the postgres-config command familywhats introduced?
postgres-config get: reads the target project's config and proves a json object payload on stdoutpostgres-config update: applies awork_memoverride with--no-restart, proves the row in its own output and through get, then removes itpostgres-config delete: seeds a override, proves it landed, deletes it, and proves get no longer returns the keyref: