fix: escape identifiers in the Python type generator#1082
Open
oniani1 wants to merge 1 commit into
Open
Conversation
Enum labels and column names are interpolated into the generated Python source without escaping, so an identifier that contains a double quote, backslash, or newline produces invalid output and can inject arbitrary text into the module. The TypeScript template already passes every name through JSON.stringify; do the same here for enum Literal values and Field aliases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python type generator interpolates enum labels and column names into the generated source without escaping, so a name that contains a double quote, backslash, or newline produces invalid Python and can inject text into the generated module. The TypeScript template already passes every identifier through
JSON.stringify. This does the same for enumLiteralvalues andFieldaliases.Added a test that generates types for an enum label and a column name containing a double quote, and checks the output stays inside the string literal. It fails without the change and passes with it.
Closes #1081