docs: evaluate Query DB Collection dependency - #24
Open
dhruvxvaishnav wants to merge 1 commit into
Open
dhruvxvaishnav wants to merge 1 commit into
dhruvxvaishnav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Summary
Recommendation
Keep
@tanstack/query-db-collectionfor now. It owns substantial generic lifecycle behavior, including on-demand subset loading, observer deduplication, row ownership across overlapping queries, result reconciliation, and cleanup. No current Supabase requirement justifies reimplementing that behavior.The next step should be an internal boundary that isolates query keys, metadata, collection capture, and Query Cache lifecycle hooks without changing
supabaseCollectionOptionsor user-visible behavior.Validation
pnpm checkon Linux with Node 22 and pnpm 9: passed with four pre-existing suppression warnings insrc/db.tspnpm typecheck: passedpnpm test: 277 passed, 9 todopnpm build: passedgit diff --check: passedpnpm test:e2e: not run locally because Docker was unavailable; this is a documentation-only change and the PR workflow runs the end-to-end suite