Retry DNS-dependent builder dials. - #5148
Draft
NullHypothesis wants to merge 3 commits into
Draft
Conversation
The remote builder's compatibility check already retries with backoff on connection failure, since a freshly created .fly.dev hostname can take a moment to become resolvable. But every dial made afterward, for the rest of the build, used a single `tls.Dial` to the same hostname. Extract `dialBuilderWithDNSRetry` with the same backoff parameters as the existing check, and use it in both dialers.
NullHypothesis
force-pushed
the
fix-dns-race
branch
from
September 1, 2026 12:47
f7f8af3 to
0421423
Compare
NullHypothesis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote builder's compatibility check already retries with backoff on connection failure, since a freshly created .fly.dev hostname can take a moment to become resolvable. But every dial made afterward, for the rest of the build, used a single
tls.Dialto the same hostname.Extract
dialBuilderWithDNSRetrywith the same backoff parameters as the existing check, and use it in both dialers.