Skip to content

Route MPGv2 detach through the Machines API - #5149

Merged
tripledoublev merged 1 commit into
masterfrom
vincent/mpg-machines-attach-detach
Sep 1, 2026
Merged

Route MPGv2 detach through the Machines API#5149
tripledoublev merged 1 commit into
masterfrom
vincent/mpg-machines-attach-detach

Conversation

@tripledoublev

Copy link
Copy Markdown
Contributor

Summary

  • route fly mpg detach through the public Machines API
  • fall back to the legacy MPGv2 API only for classified 404 responses
  • preserve existing detach output and secret-warning behavior
  • update the fly-go dependency to released v0.9.13
  • add coverage for public success, classified-404 fallback, fallback errors, and authoritative public errors

Testing

  • go test ./internal/command/mpg/v2 -run Detach -count=1
  • go test ./internal/command/mpg/... -count=1
  • go mod tidy -diff
  • go mod verify
  • go vet ./...
  • gofmt -l .
  • git diff --check
  • real disposable personal-org validation with a local build of this branch

@tomr-a5 tomr-a5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tripledoublev

Copy link
Copy Markdown
Contributor Author

thanks for the review @tomr-a5 !

@tripledoublev
tripledoublev merged commit 7084284 into master Sep 1, 2026
22 checks passed
@tripledoublev
tripledoublev deleted the vincent/mpg-machines-attach-detach branch September 1, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants