Run Buildpack preflight test using local Docker. - #5172
Merged
Conversation
Preflight tests share an organization-wide remote builder app. This causes a conflict for the `TestDeploy` preflight test: The "Buildpack" test wants a remote Docker/RCHAB builder whereas the "Dockerfile" test wants a BuildKit builder. Both use the "remote-docker-builder" app role despite exposing incompatible APIs and that has been causing problems when both tests run in parallel. To fix this, use `--local-only` for the Buildpack test. This should fix the builder app race but it comes at the cost of losing some test coverage. We need to re-architect preflight tests to safely test these two different build paths.
Contributor
Author
|
@mattp-fly, would you mind taking a look at this? Git history tells me that you're quite familiar with that code :) |
Contributor
Author
We can't afford to have flyctl's CI be this brittle. Some lost test coverage is a fair price to pay for a more robust CI. I'm gonna go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preflight tests share an organization-wide remote builder app. This causes a conflict for the
TestDeploypreflight test: The "Buildpack" test wants a remote Docker/RCHAB builder whereas the "Dockerfile" test wants a BuildKit builder. Both use the "remote-docker-builder" app role despite exposing incompatible APIs and that has been causing problems when both tests run in parallel.To fix this, use
--local-onlyfor the Buildpack test. This should fix the builder app race but it comes at the cost of losing some test coverage. We need to re-architect preflight tests to safely test these two different build paths.