Handle eventual consistency in volume tests. - #5174
Merged
Merged
Conversation
Volume creation is eventually consistent, meaning that one may not be able to retrieve a volume immediately after its creation. Preflight tests haven't been taking this into account and therefore occasionally fail with "volume not found" errors. This PR adds `require.Eventually` invocations to make these tests less brittle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volume creation is eventually consistent, meaning that one may not be able to retrieve a volume immediately after its creation. Preflight tests haven't been taking this into account and therefore occasionally fail with "volume not found" errors.
This PR adds
require.Eventuallyinvocations to make these tests less brittle.