Repository navigation
Conversation
SuperwallKit presents a paywall in a window of its own, whose root allowed every orientation, so Screen.autorotateTo* was never consulted while a paywall was up. superwall/Superwall-iOS#568 makes that window follow the app's own view controller. Require 4.19.1, the first release it can ship in, so games get the fix without pinning it themselves. Podfiles kept by an Append build are moved off any requirement an earlier version of this package wrote, not just `~> 4.0`. Those are listed by their version part only, so native-sdk-bump.yml's rewrite of the current pod line leaves them alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CR7gAmtFzGVaH1B6Mxxrga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On iOS, a landscape-only game can be rotated to portrait while a paywall is open, and it stays in portrait after the paywall closes. A customer reported this for a map that's locked to landscape through
Screen.autorotateTo*.SuperwallKit presents the paywall in its own window. That window's root is a plain
UIViewController, which allows every orientation, so Unity's orientation settings are never checked. The fix is native: superwall/Superwall-iOS#568 makes the paywall window follow the app's top view controller. For a Unity game, that's Unity's view controller, which reportsScreen.autorotateTo*. When the paywall closes, the fix also asks UIKit to check orientations again.What
SuperwallKit >= 4.19.1, < 5.0. 4.19.1 is the version staged on Superwall-iOSdevelop, so it's the first release #568 can ship in. No bridge or C# changes are needed.~> 4.0and>= 4.12.10, < 5.0). Before, only~> 4.0was moved. A requirement the developer set by hand is left alone. This logic is now a testableUpdateSuperwallKitRequirement.native-sdk-bump.yml'ssedon thepod 'SuperwallKit', '…'line no longer rewrites them too.Before merging
pod installfail.ci~/ios-harness/Package.swiftatfrom: "4.12.10". Raising it before the release would break the harness's package resolution, and the harness doesn't test orientation.Testing
Tests/Editor/PodfileRequirementTests.cs: both earlier requirements get moved, the current one is unchanged, and a hand-set pin is kept. These are Editor tests, and CI doesn't run Editor tests.Generated by Claude Code