Skip to content

Add propaganistas/laravel-phone ^6 support #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bytestream merged 4 commits into from
May 28, 2026
Merged

Add propaganistas/laravel-phone ^6 support #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
247bbba
Update dependencies
bytestream May 28, 2026
d4db05e
wip
bytestream May 28, 2026
9a636d7
wip
bytestream May 28, 2026
4421d4f
wip
bytestream May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"php": "^8.1",
"guzzlehttp/guzzle": "^7.0",
"kevinrob/guzzle-cache-middleware": "^5.0 || ^6.0 || ^7.0",
"phpdocumentor/reflection-docblock": "^5.2",
"propaganistas/laravel-phone": "^5.3",
"propaganistas/laravel-phone": "^5.3|^6.0",
"psr/http-message": "^1.1|^2.0",
"supportpal/eloquent-model": "^1.1",
"symfony/cache": "^6.2|^7.2",
Expand All @@ -23,7 +22,7 @@
"symfony/yaml": "^6.2|^7.0"
},
"require-dev": {
"brianium/paratest": "^4.0|^5.0|^6.0",
"brianium/paratest": "^6.0",
"jangregor/phpstan-prophecy": "2.2.0",
"larapack/dd": "^1.1",
"phpmd/phpmd": "^2.9",
Expand Down
5 changes: 1 addition & 4 deletions test/Unit/Model/User/Request/CreateUserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace SupportPal\ApiClient\Tests\Unit\Model\User\Request;

use Propaganistas\LaravelPhone\Exceptions\NumberParseException;
use libphonenumber\NumberParseException;
use SupportPal\ApiClient\Model\User\Request\CreateUser;
use SupportPal\ApiClient\Tests\Unit\Model\BaseModelTest;

Expand Down Expand Up @@ -35,21 +35,18 @@ public function testSetPhoneNumber(): void
public function testSetPhoneNumberInvalidNumber(): void
{
$this->expectException(NumberParseException::class);
$this->expectExceptionMessage('Number does not match the provided country.');
$this->model->setPhoneNumber('14+%595', 'US');
}

public function testSetPhoneNumberCountryRequired(): void
{
$this->expectException(NumberParseException::class);
$this->expectExceptionMessage('Number requires a country to be specified.');
$this->model->setPhoneNumber('123456789');
}

public function testSetPhoneNumberInvalidCountry(): void
{
$this->expectException(NumberParseException::class);
$this->expectExceptionMessage('Number does not match the provided country.');
$this->model->setPhoneNumber('2323247465753', 'GB');
}

Expand Down