Don't build the stdlib modules as members of the same package - #888
Merged
tshortli merged 1 commit intoSep 30, 2026
Merged
Conversation
When this project is built with SwiftPM, the `_RegexParser`, `_StringProcessing`, and `RegexBuilder` modules are all built with `-package-name swift_experimental_string_processing`. The compiler does not consider a conformance to be retroactive when the conforming type or the protocol comes from a module in the same package, so the `@retroactive` attributes in `RegexBuilder` became errors in the Swift 6 language mode and were removed. However, when these modules are built with CMake as part of the Swift toolchain, no package name is specified and the compiler instead warns that the conformances of `String`, `Substring`, `Character`, and `UnicodeScalar` to `RegexComponent` are retroactive. Opt the stdlib targets out of package access in the package manifest so that the SwiftPM build matches the toolchain build, and restore the `@retroactive` attributes.
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this project is built with SwiftPM, the
_RegexParser,_StringProcessing, andRegexBuildermodules are all built with-package-name swift_experimental_string_processing. The compiler does not consider a conformance to be retroactive when the conforming type or the protocol comes from a module in the same package, so the@retroactiveattributes inRegexBuilderbecame errors in the Swift 6 language mode and were removed. However, when these modules are built with CMake as part of the Swift toolchain, no package name is specified and the compiler instead warns that the conformances ofString,Substring,Character, andUnicodeScalartoRegexComponentare retroactive.Opt the stdlib targets out of package access in the package manifest so that the SwiftPM build matches the toolchain build, and restore the
@retroactiveattributes.Follow up to #879.