Repository navigation
jextract: skip prefix and postfix operators by their modifier - #950
Open
piercifani wants to merge 1 commit into
Open
piercifani wants to merge 1 commit into
piercifani wants to merge 1 commit into
Conversation
JavaExtractDecider meant to skip prefix and postfix operators by checking the name token for .prefixOperator or .postfixOperator. In a declaration such as `public static prefix func - (value: Number) -> Number` the name is lexed as a binary operator, and only the `prefix` modifier tells it apart. So the operator was extracted as a binary operator, and in JNI mode the Swift thunk printer stopped with `Binary operator must have exactly 2 arguments`. Check the modifiers instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaExtractDecideris meant to skip prefix and postfix operators, which have no Java mapping. It checked the declaration's name token for.prefixOperatoror.postfixOperator, but in a declaration the operator name is always lexed as a binary operator:So
-here was extracted as a binary operator. In JNI mode, generating the Swift thunks then stopped jextract:The check now looks for the
prefixorpostfixmodifier.Testing
JNIOperatorsTests, one checking the Java bindings and one the Swift thunks, with a prefix-and a postfix++next to a binary+. Onmainthey crash with the fatal error above.swift testpasses.🤖 Generated with Claude Code