[symfony] remove PreferAutowireAttributeOverConfigParamRule, too opinionated

README.md

@@ -1912,46 +1912,6 @@ return static function (ContainerConfigurator $containerConfigurator): void {
 
 <br>
 
-### PreferAutowireAttributeOverConfigParamRule
-
-Instead of parameter reference in config, add #[Autowire(param: ...)] in the "%s" class constructor
-
-```yaml
-rules:
-    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\PreferAutowireAttributeOverConfigParamRule
-```
-
-```php
-use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
-
-return static function (ContainerConfigurator $containerConfigurator): void {
-    $services = $containerConfigurator->services();
-
-    $services->set(SomeService::class)->args(['%some_param%']);
-};
-```
-
-:x:
-
-<br>
-
-```php
-use Symfony\Component\DependencyInjection\Attribute\Autowire;
-
-final class SomeService
-{
-    public function __construct(
-        #[Autowire(param: 'some_param')]
-        private string $someParam
-    ) {
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ### NoDuplicateArgsAutowireByTypeRule
 
 Instead of passing "%s" to args(), remove the line and let autowiring handle it

config/symfony-config-rules.neon

@@ -14,9 +14,6 @@ rules:
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgsAutowireByTypeRule
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoDuplicateArgAutowireByTypeRule
 
-    # #[Autowire() in-class attribute over param() in config
-    - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\PreferAutowireAttributeOverConfigParamRule
-
     # $services->set('X', 'X')
     - Symplify\PHPStanRules\Rules\Symfony\ConfigClosure\NoServiceSameNameSetClassRule
 

src/Enum/RuleIdentifier/SymfonyRuleIdentifier.php

@@ -52,8 +52,6 @@ final class SymfonyRuleIdentifier
 
     public const string REQUIRED_IS_GRANTED_ENUM = 'symfony.requiredIsGrantedEnum';
 
-    public const string PREFER_AUTOWIRE_ATTRIBUTE_OVER_CONFIG_PARAM = 'symfony.preferAutowireAttributeOverConfigParam';
-
     public const string RULE_IDENTIFIER = 'symfony.noServiceAutowireDuplicate';
 
     public const string NO_SET_CLASS_SERVICE_DUPLICATE = 'symfony.noSetClassServiceDuplicate';

src/Enum/SymfonyClass.php

@@ -41,6 +41,4 @@ final class SymfonyClass
     public const string CONTAINER_CONFIGURATOR = 'Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator';
 
     public const string IS_GRANTED = 'Symfony\Component\Security\Http\Attribute\IsGranted';
-
-    public const string ATTRIBUTE = 'Symfony\Component\DependencyInjection\Attribute\Autowire';
 }

src/Enum/SymfonyFunctionName.php

@@ -9,6 +9,4 @@ final class SymfonyFunctionName
     public const string REF = 'Symfony\Component\DependencyInjection\Loader\Configurator\ref';
 
     public const string SERVICE = 'Symfony\Component\DependencyInjection\Loader\Configurator\service';
-
-    public const string PARAM = 'Symfony\Component\DependencyInjection\Loader\Configurator\param';
 }