Make complexity/configurable/static sets toggleable, drop duplicate naming-rules include - #304
Merged
Merged
Conversation
…uplicate naming-rules include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running PHPStan in a project that uses
phpstan/extension-installerand also includesconfig/symplify-rules.neonprints:naming-rules.neonis auto-loaded by the extension-installer (viaextra.phpstan.includes) and gated by thesymplify.namingtoggle. Butsymplify-rules.neonincludes it a second time, unconditionally - hence the duplicate.Change
naming-rules.neoninclude fromsymplify-rules.neon. It stays enabled via the existingsymplify.naming: truedefault and the auto-load.code-complexity-rules.neon,configurable-rules.neonandstatic-rules.neonthe sameconditionalTagstreatment asnaming-rules.neon, gated by newsymplify.complexity,symplify.configurableandsymplify.staticparams (all defaulttrue, so no behavior change on upgrade).Now each set can be turned off from config:
Verification
rules:shorthand, explicitservices:, anonymous services with arguments): with the flagtruethe rule fires, withfalseit is silent, params resolve with no config errors.