[doctrine] Suggest fetching repository from test container in test classes

phpstan.neon

@@ -41,6 +41,7 @@ parameters:
 
         # used in tests
         - '#Public constant "Symplify\\PHPStanRules\\(.*?)Rule\:\:ERROR_MESSAGE" is never used#'
+        - '#Public constant "Symplify\\PHPStanRules\\(.*?)Rule\:\:TEST_ERROR_MESSAGE" is never used#'
 
         -
             message: '#Generator expects value type array<string, mixed>, list<bool\|float\|int\|list<string>\|PHPStan\\TrinaryLogic\|string\|null> given#'

src/Rules/Doctrine/NoGetRepositoryOutsideServiceRule.php

@@ -15,6 +15,7 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\DoctrineRuleIdentifier;
 use Symplify\PHPStanRules\Helper\NamingHelper;
+use Symplify\PHPStanRules\PHPUnit\TestClassDetector;
 
 /**
  * @see \Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\NoGetRepositoryOutsideServiceRuleTest
@@ -25,6 +26,8 @@ final class NoGetRepositoryOutsideServiceRule implements Rule
 {
     public const string ERROR_MESSAGE = 'Instead of getting repository from EntityManager, use constructor injection and service pattern to keep code clean';
 
+    public const string TEST_ERROR_MESSAGE = 'Instead of getting repository from EntityManager, fetch the repository service directly from the test container';
+
     public function getNodeType(): string
     {
         return MethodCall::class;
@@ -61,7 +64,9 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
+        $errorMessage = TestClassDetector::isTestClass($scope) ? self::TEST_ERROR_MESSAGE : self::ERROR_MESSAGE;
+
+        $ruleError = RuleErrorBuilder::message($errorMessage)
             ->identifier(DoctrineRuleIdentifier::NO_GET_REPOSITORY_OUTSIDE_SERVICE)
             ->build();
 

tests/Rules/Doctrine/NoGetRepositoryOutsideServiceRule/Fixture/GetRepositoryInsideContext.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Fixture;
+
+use Doctrine\ORM\EntityManager;
+use Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Source\SomeRandomEntity;
+
+final class GetRepositoryInsideContext
+{
+    public function __construct(
+        private EntityManager $entityManager
+    ) {
+    }
+
+    public function run(): void
+    {
+        $someRepository = $this->entityManager->getRepository(SomeRandomEntity::class);
+    }
+}

tests/Rules/Doctrine/NoGetRepositoryOutsideServiceRule/NoGetRepositoryOutsideServiceRuleTest.php

@@ -36,6 +36,11 @@ public static function provideData(): Iterator
             19,
         ]]];
 
+        yield [__DIR__ . '/Fixture/GetRepositoryInsideContext.php', [[
+            NoGetRepositoryOutsideServiceRule::TEST_ERROR_MESSAGE,
+            19,
+        ]]];
+
         yield [__DIR__ . '/Fixture/SkipInRepository.php', []];
         yield [__DIR__ . '/Fixture/SkipDynamicFetch.php', []];
         yield [__DIR__ . '/Fixture/SkipDynamicClassConstFetch.php', []];