Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@
__DIR__ . '/src/Rules/Symfony/ConstraintMustHaveAttributeRule.php',
__DIR__ . '/tests/Naming/ClassToSuffixResolverTest.php',
__DIR__ . '/src/Doctrine/DoctrineEntityDocumentAnalyser.php',
__DIR__ . '/src/Collector/NewWithFollowingSettersCollector.php',
],
]);
20 changes: 17 additions & 3 deletions src/Collector/NewWithFollowingSettersCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
use PhpParser\NodeFinder;
use PHPStan\Analyser\Scope;
use PHPStan\Collectors\Collector;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\ReflectionProvider;
use Symfony\Component\HttpKernel\Kernel;
use Webmozart\Assert\Assert;
Expand Down Expand Up @@ -159,11 +160,24 @@ private function shouldSkipClass(string $className): bool
return true;
}

// skip Doctrine entities
$fileContents = file_get_contents($classReflection->getFileName());
// skip Doctrine entities, they are usually set/get magically
return $this->isDoctrineEntity($classReflection);
}

private function isDoctrineEntity(ClassReflection $classReflection): bool
{
// #[ORM\Entity] attribute
foreach ($classReflection->getNativeReflection()->getAttributes() as $attributeReflection) {
if ($attributeReflection->getName() === 'Doctrine\ORM\Mapping\Entity') {
return true;
}
}

// @ORM\Entity annotation fallback
$fileContents = file_get_contents((string) $classReflection->getFileName());
Assert::string($fileContents);

return str_contains($fileContents, '@ORM\Entity') || str_starts_with($fileContents, '#[Entity]');
return str_contains($fileContents, '@ORM\Entity');
}

/**
Expand Down
24 changes: 24 additions & 0 deletions tests/Rules/NewOverSettersRule/Fixture/SkipAttributeEntity.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php

declare(strict_types=1);

namespace Symplify\PHPStanRules\Tests\Rules\NewOverSettersRule\Fixture;

use Symplify\PHPStanRules\Tests\Rules\NewOverSettersRule\Source\SomeAttributeEntity;

final class SkipAttributeEntity
{
public function first()
{
$alwaysSetters = new SomeAttributeEntity();
$alwaysSetters->setName('John');
$alwaysSetters->setAge(25);
}

public function second()
{
$alwaysSetters = new SomeAttributeEntity();
$alwaysSetters->setName('Doe');
$alwaysSetters->setAge(35);
}
}
1 change: 1 addition & 0 deletions tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public static function provideData(): Iterator

yield [__DIR__ . '/Fixture/SkipSomeKernel.php', []];
yield [__DIR__ . '/Fixture/SkipEntity.php', []];
yield [__DIR__ . '/Fixture/SkipAttributeEntity.php', []];
yield [__DIR__ . '/Fixture/SkipNotSetterCall.php', []];
yield [__DIR__ . '/Fixture/SkipNoArgSetters.php', []];
}
Expand Down
17 changes: 17 additions & 0 deletions tests/Rules/NewOverSettersRule/Source/SomeAttributeEntity.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace Symplify\PHPStanRules\Tests\Rules\NewOverSettersRule\Source;

use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity]
class SomeAttributeEntity
{
public function setName(string $name)
{
}

public function setAge(int $age)
{
}
}
Loading