[symfony] skip NoFindTaggedServiceIdsCallRule in test classes

src/Rules/Symfony/NoFindTaggedServiceIdsCallRule.php

@@ -12,6 +12,7 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\SymfonyRuleIdentifier;
 use Symplify\PHPStanRules\Helper\NamingHelper;
+use Symplify\PHPStanRules\PHPUnit\TestClassDetector;
 
 /**
  * @implements Rule<MethodCall>
@@ -35,6 +36,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        // tagged service ids are commonly used in tests to assert service registration
+        if (TestClassDetector::isTestClass($scope)) {
+            return [];
+        }
+
         $identifierRuleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
             ->identifier(SymfonyRuleIdentifier::NO_FIND_TAGGED_SERVICE_IDS_CALL)
             ->build();

tests/Rules/Symfony/NoFindTaggedServiceIdsCallRule/Fixture/FindTaggedServiceIdsInPass.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoFindTaggedServiceIdsCallRule\Fixture;
+
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+final class FindTaggedServiceIdsInPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $containerBuilder): void
+    {
+        $taggedServiceIds = $containerBuilder->findTaggedServiceIds('some_tag');
+    }
+}

tests/Rules/Symfony/NoFindTaggedServiceIdsCallRule/Fixture/SkipFindTaggedServiceIdsInContext.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoFindTaggedServiceIdsCallRule\Fixture;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+final class SkipFindTaggedServiceIdsInContext
+{
+    public function test(ContainerBuilder $containerBuilder): void
+    {
+        $taggedServiceIds = $containerBuilder->findTaggedServiceIds('some_tag');
+    }
+}

tests/Rules/Symfony/NoFindTaggedServiceIdsCallRule/NoFindTaggedServiceIdsCallRuleTest.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\NoFindTaggedServiceIdsCallRule;
+
+use Iterator;
+use Override;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Symplify\PHPStanRules\Rules\Symfony\NoFindTaggedServiceIdsCallRule;
+
+/**
+ * @extends RuleTestCase<NoFindTaggedServiceIdsCallRule>
+ */
+final class NoFindTaggedServiceIdsCallRuleTest extends RuleTestCase
+{
+    /**
+     * @param list<array{0: string, 1: int}> $expectedErrorsWithLines
+     */
+    #[DataProvider('provideData')]
+    public function testRule(string $filePath, array $expectedErrorsWithLines): void
+    {
+        $this->analyse([$filePath], $expectedErrorsWithLines);
+    }
+
+    /**
+     * @return Iterator<array<array<int, mixed>, mixed>>
+     */
+    public static function provideData(): Iterator
+    {
+        yield [__DIR__ . '/Fixture/FindTaggedServiceIdsInPass.php', [[NoFindTaggedServiceIdsCallRule::ERROR_MESSAGE, 14]]];
+
+        yield [__DIR__ . '/Fixture/SkipFindTaggedServiceIdsInContext.php', []];
+    }
+
+    /**
+     * @return string[]
+     */
+    #[Override]
+    public static function getAdditionalConfigFiles(): array
+    {
+        return [__DIR__ . '/config/configured_rule.neon'];
+    }
+
+    protected function getRule(): Rule
+    {
+        return self::getContainer()->getByType(NoFindTaggedServiceIdsCallRule::class);
+    }
+}

tests/Rules/Symfony/NoFindTaggedServiceIdsCallRule/config/configured_rule.neon

@@ -0,0 +1,5 @@
+includes:
+    - ../../../../config/included_services.neon
+
+rules:
+    - Symplify\PHPStanRules\Rules\Symfony\NoFindTaggedServiceIdsCallRule