[symfony] allow 2nd dynamic arg in SingleArgEventDispatchRule

src/Rules/Symfony/SingleArgEventDispatchRule.php

@@ -39,11 +39,21 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        $args = $node->getArgs();
+
         // all good
-        if (count($node->getArgs()) === 1) {
+        if (count($args) === 1) {
             return [];
         }
 
+        // allow 2nd arg when dynamic, e.g. a variable event name
+        if (count($args) === 2) {
+            $secondArgType = $scope->getType($args[1]->value);
+            if ($secondArgType->getConstantStrings() === []) {
+                return [];
+            }
+        }
+
         $callerType = $scope->getType($node->var);
         if (! $callerType instanceof ObjectType) {
             return [];

tests/Rules/Symfony/SingleArgEventDispatchRule/Fixture/SkipDynamicSecondArg.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\Symfony\SingleArgEventDispatchRule\Fixture;
+
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+
+final class SkipDynamicSecondArg
+{
+    public function run(EventDispatcherInterface $eventDispatcher, object $event, string $name)
+    {
+        $eventDispatcher->dispatch($event, $name);
+    }
+}

tests/Rules/Symfony/SingleArgEventDispatchRule/SingleArgEventDispatchRuleTest.php

@@ -30,6 +30,7 @@ public static function provideData(): Iterator
 
         yield [__DIR__ . '/Fixture/SkipSingleDispatch.php', []];
         yield [__DIR__ . '/Fixture/SkipUnrelatedDispatch.php', []];
+        yield [__DIR__ . '/Fixture/SkipDynamicSecondArg.php', []];
     }
 
     protected function getRule(): Rule