[doctrine] Skip unconvertible builders in RequireQueryBuilderOnRepositoryRule - #312
Merged
Merged
Conversation
…uireQueryBuilderOnRepositoryRule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule flagged every
$entityManager->createQueryBuilder()call inside a repository, including builders that cannot be swapped for$this->createQueryBuilder():update()/delete()builders - the repository shortcut only produces SELECTsfrom()on another entity than the repository owns - e.g. cross-entity subqueries;$this->createQueryBuilder()always FROMs the repository entityThose forced an inline
@phpstan-ignoreon otherwise-correct code. The rule now inspects what the produced query builder does (both fluent chains and via an intermediate variable) and skips these cases, while still reporting the convertible ones - including a plain builder orfrom()on the repository entity, and per-builder within a method that mixes a main self query with a cross-entity subquery.The repository entity is resolved from the
EntityRepository<T>/DocumentRepository<T>generic.Tests cover fluent + assigned variants of each skip case, a self-entity report, and a mixed-builders method.